fix(app): fix slot validation on ODD location conflict check to account for thermocycler occupying 2 slots #15239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyBatten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Slot conflict checking did not account for the fact that the thermocycler (and any future multi-slot fixture) was composed of multiple fixtures. This means that the expected fixture (thermocycler front) was not returned, because thermocycler rear occupies the first slot in the list.
Test Plan
Upload a protocol requiring a thermocycler to a Flex, ensure that from the main protocol list view page and the protocol dashboard do not list a location conflict.
Risk assessment
low