fix(shared-data): raise uiMaxFlowRate values to match the default blowout and dispense #15238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wout and dispense closes RQA-2722
sfoster1
reviewed
May 21, 2024
sfoster1
approved these changes
May 22, 2024
ryanthecoder
pushed a commit
that referenced
this pull request
May 28, 2024
…wout and dispense (#15238) closes RQA-2722 A few of the `uiMaxFlowRate` values were not high enough to account for the default `blowout` and `dispense` flow rates. Rather than changing those flow rates, I raised the `uiMaxFlowRate`s for those pipette models. This required me to modify the test to expect the failures for those models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-2722
Overview
A few of the
uiMaxFlowRatevalues were not high enough to account for the defaultblowoutanddispenseflow rates. Rather than changing those flow rates, I raised theuiMaxFlowRates for those pipette models. This required me to modify the test to expect the failures for those models.Those models include:
"p50_single_v3.4", "p50_single_v3.5", "p50_single_v3.6", "p50_multi_v3.5", "p50_multi_v3.4"Test Plan
verify that my test changes and comment make sense
Changelog
Review requests
see test plan
Risk assessment
low