fix(app): instead filter magnetic blocks (not magnetic modules) out of the required modules #15232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the required modules Fix bug where we were accidentally filtering magnetic modules instead of magnetic blocks from the required modules list from analysis. Closes RQA-2754
b-cooper
requested review from
jerader
and removed request for
a team and
jerader
CaseyBatten
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix bug where we were accidentally filtering magnetic modules instead of magnetic blocks from the
required modules list from analysis.
Closes RQA-2754
Review requests
send a protocol that requires the magnetic block to a Flex. From the Protocol detail page of the ODD, there should only be one listing for that required magnetic block in the hardware list. There should also be no incorrect location conflicts.
Risk assessment
low