Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): clear intervention modal if run is finishing #15209

Merged
merged 2 commits into from
May 16, 2024
Merged

fix(app): clear intervention modal if run is finishing #15209

merged 2 commits into from
May 16, 2024

Conversation

ncdiehl11
Copy link
Collaborator

Closes RQA-2730

Overview

Remove InterventionModal if run is finishing. Implement useNotifyLastRunCommand in desktop RunProgressMeter

Test Plan

  • run a protocol in which the last command is an intervention command (pause, etc.)
  • resume the protocol on desktop app
  • verify that the modal clears when the run is finishing
  • repeat the above steps on ODD

Changelog

  • introduce useNotifyLastRunCommand hook to RunProgressMeter
  • check for run finishing status to remove intervention modal

Review requests

@b-cooper per work together

Risk assessment

low

@ncdiehl11
fix(app): clear intervention modal if run is finishing
a2909e3 
Remove InterventionModal if run is finishing. Implement useNotifyLastRunCommand in desktop
RunProgressMeter

Closes RQA-2730
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 16, 2024 22:14
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 16, 2024 22:14
@ncdiehl11 ncdiehl11 requested review from b-cooper and removed request for a team May 16, 2024 22:14
b-cooper
b-cooper approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We both agreed that you can revert the RunProgressMeter change, but after that reversion, this looks good to go

@ncdiehl11 ncdiehl11 merged commit 76cbb52 into chore_release-7.3.0 May 16, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-intervention-modal branch May 17, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-cooper b-cooper b-cooper approved these changes

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @b-cooper