fix(app): disable exit button after successful pipette attach/detach #15205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and 1 click After a pipette is attached or detached successfully, the exit button should only be clickable once, so that many home commands are not emitted in rapid succession with each click. Closes RQA-2731
ncdiehl11
changed the title
|
This looks good - but I'm wondering what happens if you press "Calibrate Pipette Offset" after pressing exit? Maybe we should disable both buttons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-2731
Overview
On OT-2, after a pipette is attached or detached successfully, the exit button should only be clickable once, so that many home commands are not emitted in rapid succession with each click.
Screen.Recording.2024-05-16.at.2.44.13.PM.mov
Screen.Recording.2024-05-16.at.2.44.59.PM.mov
Test Plan
Changelog
isDisabledprop to success exit buttonReview requests
js
Risk assessment
low