fix(app): properly fall back to load order module matching on map view OT2 module setup #15204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w OT2 module setup Don't look to deck configuration for matching specced modules to attached modules within the module setup step of the OT2 Closes RQA-2735
b-cooper
force-pushed
the
app_fix-module-map-ot2-moam
branch
from
a0a35d1 to
5d649f0
Compare
b-cooper
requested review from
mjhuff,
smb2268,
brenthagen and
ncdiehl11
and removed request for
a team and
mjhuff
ncdiehl11
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Don't look to deck configuration for matching specced modules to attached modules within the module
setup step of the OT-2
Closes RQA-2735
Review requests
confirm that multiples of a module works as expected in protocol setup on an OT-2
Risk assessment
low