Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): wait for maintenance run deletion before closing flows #15201

Merged
merged 1 commit into from
May 16, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented May 16, 2024

fix RABR-290

Overview

In two previous PR's we stopped waiting for a maintenance run to get deleted before closing gripper and wizard flows. This fixed a few visual bugs where the spinner was removed before the modals closed, but caused a bug where you could try to create a new maintenance run before the previous one was deleted. This PR adds back in waiting for the delete mutation to resolve before exiting and adds logic to show the spinner while the mutation is loading.

Test Plan

  1. Ensure this fixes the bug where opening, quickly closing, and opening another gripper flow causes a 500 error since the deletion isn't complete before another is created
  2. Exit out of pipette and gripper flows and ensure the loader shows from the time the home begins to the time the modal is closed

Changelog

  1. Move closeFlow() back to the resolve call back of useDeleteMaintenanceRunMutation
  2. Grab isLoading from the same mutation and use it wherever we show a spinner

Review requests

Quick code check - @ncdiehl11, @vegano1 and I have done some testing on this

Risk assessment

Low

@smb2268 smb2268 requested review from vegano1 and ncdiehl11 May 16, 2024 18:27
@smb2268 smb2268 self-assigned this May 16, 2024
@smb2268 smb2268 requested a review from a team as a code owner May 16, 2024 18:27
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and code looks good to me. thanks!

@smb2268 smb2268 merged commit 97da85c into chore_release-7.3.0 May 16, 2024
25 of 26 checks passed
@smb2268 smb2268 deleted the app_fix-maintenance-delete branch May 16, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants