Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add known issue for losing LPC offsets when swapping labware type via RTP #15194

Merged
merged 1 commit into from
May 16, 2024

Conversation

ecormany
Copy link
Contributor

Overview

Letting people know they can get chicken-and-egg'd if they apply labware offsets, set RTPs that change their labware, and then reanalysis gets rid of their original offsets.

Review requests

Is this clear? This is kind of a tricky one to wrap up in a single sentence.

Risk assessment

zip

@ecormany ecormany requested a review from nusrat813 May 16, 2024 01:05
@ecormany ecormany requested a review from a team as a code owner May 16, 2024 01:05
@ecormany ecormany requested review from jerader and removed request for a team May 16, 2024 01:05
Copy link

@nusrat813 nusrat813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecormany ecormany merged commit ecd6ab0 into chore_release-7.3.0 May 16, 2024
26 checks passed
ecormany added a commit that referenced this pull request May 21, 2024
…ng reanalysis (#15195)

# Overview

Testing revealed that labware offsets aren't applied to labware that are
only loaded as the result of custom RTP values. This is somewhat
expected, due to the order of operations: analyze -> apply offsets ->
choose RTP values -> reanalyze.

This docs addition goes into much greater detail than the very short
summary we could fit into the release notes (see #15194).

# Test Plan


[Sandbox](http://sandbox.docs.opentrons.com/docs-rtp-plate-swap/v2/parameters/using_values.html#limitations)

# Review requests

Is this too much? Will it all be rendered moot by a hotfix?

# Risk assessment

none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants