refactor(react-api-client): fix react query key object hashing for useAllCommandsAsPreSerializedList #15188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eAllCommandsAsPreSerializedList React query does not properly handle objects passed in useQuery's queryKey array argument that contain keys with `undefined` values. Here, in one instance, I map undefined values to null so that they are properly cached and do not trigger a refetch when the host object does not change.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
React query does not properly handle objects passed in useQuery's queryKey array argument that contain keys with
undefinedvalues. Here, inuseAllCommandsAsPreSerializedList, I map undefined values to null so that they are properly cached and do not trigger a refetch when the host object does not change.In the future, I will provide a utility for all
react-api-clienthooks that will sanitize objects with possible undefined values to be included in the queryKey.tanstack reference
Test Plan
Changelog
hostobjectundefinedvalues tonullReview requests
@b-cooper per collab
Risk assessment
low