Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data) Update tip overlap values for Flex Pipettes #15147

Merged
merged 5 commits into from
May 10, 2024
Merged

fix(shared-data) Update tip overlap values for Flex Pipettes #15147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d27a1d2
update tipoverlap values V3.6
Carlos-fernandez May 9, 2024
62d8cef
updated tipoverlap values on 3_5 and 3_4
Carlos-fernandez May 9, 2024
6a9a12f
updated all files
Carlos-fernandez May 9, 2024
6471371
format
sfoster1 May 9, 2024
e6edb14
tests
sfoster1 May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5,968 changes: 0 additions & 5,968 deletions shared-data/js/__tests__/__snapshots__/pipettes.test.ts.snap
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions shared-data/js/__tests__/pipettes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ describe('pipette data accessors', () => {
'#/pipette/schemas/2/pipetteLiquidPropertiesSchema.json',
defaultTipOverlapDictionary: {
default: 10.5,
'opentrons/opentrons_flex_96_tiprack_1000ul/1': 10.5,
'opentrons/opentrons_flex_96_tiprack_200ul/1': 10.5,
'opentrons/opentrons_flex_96_tiprack_50ul/1': 10.5,
'opentrons/opentrons_flex_96_filtertiprack_1000ul/1': 10.5,
'opentrons/opentrons_flex_96_filtertiprack_200ul/1': 10.5,
'opentrons/opentrons_flex_96_filtertiprack_50ul/1': 10.5,
'opentrons/opentrons_flex_96_tiprack_1000ul/1': 9.65,
'opentrons/opentrons_flex_96_tiprack_200ul/1': 9.76,
'opentrons/opentrons_flex_96_tiprack_50ul/1': 10.09,
'opentrons/opentrons_flex_96_filtertiprack_1000ul/1': 9.65,
'opentrons/opentrons_flex_96_filtertiprack_200ul/1': 9.76,
'opentrons/opentrons_flex_96_filtertiprack_50ul/1': 10.09,
},
defaultTipracks: [
'opentrons/opentrons_flex_96_tiprack_1000ul/1',
Expand Down Expand Up @@ -150,8 +150,8 @@ describe('pipette data accessors', () => {
$otSharedSchema: '#/pipette/schemas/2/pipetteLiquidPropertiesSchema.json',
defaultTipOverlapDictionary: {
default: 10.5,
[tiprackFilter50uL]: 10.5,
[tiprack50uL]: 10.5,
[tiprackFilter50uL]: 10.09,
[tiprack50uL]: 10.09,
},
defaultTipracks: [tiprack50uL, tiprackFilter50uL],
maxVolume: 50,
Expand Down Expand Up @@ -198,8 +198,8 @@ describe('pipette data accessors', () => {
$otSharedSchema: '#/pipette/schemas/2/pipetteLiquidPropertiesSchema.json',
defaultTipOverlapDictionary: {
default: 10.5,
[tiprackFilter50uL]: 10.5,
[tiprack50uL]: 10.5,
[tiprackFilter50uL]: 10.09,
[tiprack50uL]: 10.09,
},
defaultTipracks: [tiprack50uL, tiprackFilter50uL],
maxVolume: 30,
Expand Down
2 changes: 0 additions & 2 deletions shared-data/js/labwareTools/__tests__/__snapshots__/createIrregularLabware.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`test createIrregularLabware function > failing to validate against labware schema throws w/o "strict" 1`] = `[Error: Generated labware failed to validate, please check your inputs]`;

exports[`test createIrregularLabware function failing to validate against labware schema throws w/o "strict" 1`] = `"Generated labware failed to validate, please check your inputs"`;
2 changes: 0 additions & 2 deletions shared-data/js/labwareTools/__tests__/__snapshots__/createLabware.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`createLabware > failing to validate against labware schema throws w/o "strict" 1`] = `[Error: Generated labware failed to validate, please check your inputs]`;

exports[`createLabware failing to validate against labware schema throws w/o "strict" 1`] = `"Generated labware failed to validate, please check your inputs"`;
12 changes: 6 additions & 6 deletions shared-data/pipette/definitions/2/liquid/eight_channel/p1000/default/3_4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,12 +345,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.1,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.17,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.1,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.17
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.42,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.67,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.42,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.67
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
12 changes: 6 additions & 6 deletions shared-data/pipette/definitions/2/liquid/eight_channel/p1000/default/3_5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.1,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.17,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.1,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.17
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.42,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.67,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.42,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.67
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/eight_channel/p50/default/3_4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/eight_channel/p50/default/3_5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/eight_channel/p50/lowVolumeDefault/3_4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53
},
"maxVolume": 30,
"minVolume": 1,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/eight_channel/p50/lowVolumeDefault/3_5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53
},
"maxVolume": 30,
"minVolume": 1,
Expand Down
12 changes: 6 additions & 6 deletions shared-data/pipette/definitions/2/liquid/ninety_six_channel/p1000/default/3_4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.16,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.74,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.74,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.16
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
12 changes: 6 additions & 6 deletions shared-data/pipette/definitions/2/liquid/ninety_six_channel/p1000/default/3_5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.16,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.74,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.74,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.16
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
6 changes: 3 additions & 3 deletions shared-data/pipette/definitions/2/liquid/ninety_six_channel/p1000/default/3_6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.16,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.74
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
12 changes: 6 additions & 6 deletions shared-data/pipette/definitions/2/liquid/single_channel/p1000/default/3_4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,12 +271,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
12 changes: 6 additions & 6 deletions shared-data/pipette/definitions/2/liquid/single_channel/p1000/default/3_5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
12 changes: 6 additions & 6 deletions shared-data/pipette/definitions/2/liquid/single_channel/p1000/default/3_6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/single_channel/p50/default/3_4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/single_channel/p50/default/3_5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/single_channel/p50/default/3_6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/single_channel/p50/lowVolumeDefault/3_4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 30,
"minVolume": 1,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/single_channel/p50/lowVolumeDefault/3_5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 30,
"minVolume": 1,
Expand Down
4 changes: 2 additions & 2 deletions shared-data/pipette/definitions/2/liquid/single_channel/p50/lowVolumeDefault/3_6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 30,
"minVolume": 1,
Expand Down
Loading