Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fix background color on magnetic module slideout data #15140

Merged
merged 1 commit into from
May 9, 2024
Merged

fix(app): fix background color on magnetic module slideout data #15140

merged 1 commit into from
May 9, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented May 9, 2024 •
edited
Loading

closes RQA-2515

Overview

According to designs, the background for magnetic module slideout height range table should be grey20, not grey10.
Screenshot 2024-05-09 at 1 56 17 PM

Test Plan

  • connect to robot with magnetic module attached
  • click overflow menu on magnetic module card
  • select set module height
  • verify that background color is grey20 (#E9E9E9)

Changelog

  • update background color
  • add test for style

Review requests

js

Risk assessment

low

@ncdiehl11
fix(app): fix background color on magnetic module slideout data
2978ade 
According to designs, the background for magnetic module slideout height range table should be
grey20, not grey10.
@ncdiehl11 ncdiehl11 self-assigned this May 9, 2024
@ncdiehl11 ncdiehl11 requested review from koji and jerader May 9, 2024 14:20
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 9, 2024 14:20
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 9, 2024 14:20
koji
koji approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and thanks for adding the test.

Before merging this into the target, please post a screenshot to the ticket and get Mel's approval.

@ncdiehl11 ncdiehl11 merged commit de2ada8 into chore_release-7.3.0 May 9, 2024
26 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-magmod-slideout-style branch May 9, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @koji