Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): ensure liquids nested in labware on adapter in module show on liquid map #15132

Merged
merged 1 commit into from
May 9, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented May 8, 2024

closes RQA-2699

Overview

At protocol setup on desktop, when viewing liquid setup > map view, liquids are incorrectly set to null for labware nested on an adapter, which is in turn nested on a module. We need to pass the topmost nested labware to getWellFillFromLabwareId to correctly return populated well fill.

Test Plan

  • start setup on a protocol that loads liquids in a labware on top of an adapter on top of a module (like RiboZero_Plus_8_standard_lw.py linked here)
  • open accordion for Liquid Setup and select map view
  • observe the nested labware (slot D1 if using the above linked example) can be clicked and correctly shows loaded liquids

Changelog

  • access top labware of nested adapters + labware on modules when getting well fill

Review requests

js

Risk assessment

low

…on liquid map

At protocol setup on desktop, when viewing liquid setup > map view, liquids are incorrectly set to
null for labware nested on an adapter, which is in turn nested on a module. We need to pass the
topmost nested labware to getWellFillFromLabwareId to correctly return populated well fill.
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 8, 2024 16:47
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 8, 2024 16:47
@ncdiehl11 ncdiehl11 requested review from smb2268, koji and jerader and removed request for a team May 8, 2024 16:47
@ncdiehl11 ncdiehl11 self-assigned this May 8, 2024
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈
worked as expected

@ncdiehl11 ncdiehl11 merged commit a78ea71 into chore_release-7.3.0 May 9, 2024
26 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-liquid-in-adapter branch May 9, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants