Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shared-data): fix deploy to npm github action #15123

Merged
merged 1 commit into from
May 8, 2024

Conversation

shlokamin
Copy link
Member

Overview

Oops I forgot to explicitly install dependencies for usb detection. This PR does that so that we can successfully publish shared-data to npm

Risk assessment

Low

@shlokamin shlokamin marked this pull request as ready for review May 7, 2024 20:27
@shlokamin shlokamin requested a review from a team as a code owner May 7, 2024 20:27
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭕ ⭕ ps

@shlokamin shlokamin force-pushed the shared_data-fix-npm-publish branch from c99ba8e to 6dd3555 Compare May 7, 2024 21:38
@shlokamin shlokamin requested review from a team as code owners May 7, 2024 21:38
@shlokamin shlokamin requested review from ncdiehl11 and removed request for a team May 7, 2024 21:38
@shlokamin shlokamin changed the base branch from edge to chore_release-7.3.0 May 7, 2024 21:38
@shlokamin shlokamin merged commit 49cdabc into chore_release-7.3.0 May 8, 2024
24 checks passed
@shlokamin shlokamin deleted the shared_data-fix-npm-publish branch May 8, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants