Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): ensure terminal run preview shows detail for load liquid commands #15120

Merged
merged 1 commit into from
May 8, 2024
Merged

fix(app): ensure terminal run preview shows detail for load liquid commands #15120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api-client/src/runs/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type {
Liquid,
LoadedLabware,
LoadedModule,
LoadedPipette,
Expand Down Expand Up @@ -46,6 +47,7 @@ export interface LegacyGoodRunData {
pipettes: LoadedPipette[]
labware: LoadedLabware[]
modules: LoadedModule[]
liquids: Liquid[]
protocolId?: string
labwareOffsets?: LabwareOffset[]
runTimeParameters: RunTimeParameter[]
Expand Down
8 changes: 8 additions & 0 deletions app/src/organisms/InterventionModal/__fixtures__/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
import type { RunData } from '@opentrons/api-client'
import type {
LabwareDefinitionsByUri,
Liquid,
LoadedLabware,
LoadedModule,
} from '@opentrons/shared-data'
Expand Down Expand Up @@ -176,6 +177,12 @@ export const mockThermocyclerModule: LoadedModule = {
serialNumber: 'dummySerialTC',
}

export const mockLiquid: Liquid = {
id: 'mockLiquid',
displayName: 'mock liquid',
description: 'this is my mock liquid description',
}

export const mockRunData: RunData = {
id: 'mockRunData',
createdAt: '',
Expand All @@ -188,6 +195,7 @@ export const mockRunData: RunData = {
pipettes: [],
labware: [mockLabwareOnModule, mockLabwareOnSlot, mockLabwareOffDeck],
modules: [mockModule],
liquids: [mockLiquid],
runTimeParameters: [],
}

Expand Down
1 change: 1 addition & 0 deletions app/src/organisms/RunPreview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ export const RunPreviewComponent = (
labware: runRecord.data.labware ?? [],
modules: runRecord.data.modules ?? [],
pipettes: runRecord.data.pipettes ?? [],
liquids: runRecord.data.liquids ?? [],
commands: commands,
}
: robotSideAnalysis
Expand Down
9 changes: 9 additions & 0 deletions app/src/organisms/RunTimeControl/__fixtures__/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export const mockPausedRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand All @@ -66,6 +67,7 @@ export const mockPauseRequestedRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand Down Expand Up @@ -96,6 +98,7 @@ export const mockRunningRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand Down Expand Up @@ -136,6 +139,7 @@ export const mockFailedRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand Down Expand Up @@ -171,6 +175,7 @@ export const mockStopRequestedRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand Down Expand Up @@ -206,6 +211,7 @@ export const mockStoppedRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand Down Expand Up @@ -236,6 +242,7 @@ export const mockSucceededRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand All @@ -250,6 +257,7 @@ export const mockIdleUnstartedRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand Down Expand Up @@ -280,6 +288,7 @@ export const mockIdleStartedRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand Down
2 changes: 2 additions & 0 deletions react-api-client/src/runs/__fixtures__/runs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export const mockPausedRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand Down Expand Up @@ -62,6 +63,7 @@ export const mockRunningRun: RunData = {
pipettes: [],
labware: [],
modules: [],
liquids: [],
runTimeParameters: [],
}

Expand Down
Loading