-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol-designer): misc bugs with copy, ui, and liquid color error #15116
Conversation
@@ -117,7 +117,7 @@ export function LiquidEditForm(props: LiquidEditFormProps): JSX.Element { | |||
serialize: values.serialize || false, | |||
}) | |||
} | |||
|
|||
console.log('errors', errors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to keep for debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooops forgot to delete it, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. The sandbox worked as expected.
Once the images are replaced, this pr is good to go.
@koji thanks! i think i'll fix the images in a follow up since i'm still waiting for design to give me the new images with the transparent background. In that followup i'll also update all the images to the optimized versions you made. |
that totally makes sense |
closes AUTH-386 AUTH-387 AUTH-385 partially RQA-2682
Overview
This PR addresses a handful of random things found in candidate-A for PD 8.1:
Test Plan
000000
, see that there is an error message saying its an invalid color.1mm
.Changelog
equipmentOption
to include the pipette tip type and adjust the tooltip text and disabled stateReview requests
see test plan
Risk assessment
low