Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): update disabled style of ProtocolSetupStep description #15115

Merged
merged 1 commit into from
May 7, 2024
Merged

fix(app): update disabled style of ProtocolSetupStep description #15115

merged 1 commit into from
May 7, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented May 7, 2024 •
edited
Loading

Overview

Set new description text of ProtocolSetupStep to grey50 if disabled

Screenshot 2024-05-07 at 12 12 11 PM

Test Plan

  • start RTP protocol setup on ODD
  • confirm values
  • observe disabled state of parameters

Changelog

  • set ProtocolSetupStep description color depending on disabled state

Review requests

auth js

Risk assessment

low

@ncdiehl11
fix(app): update disabled style of ProtocolSetupStep description
163cf3d 
Set new description text of ProtocolSetupStep to grey50 if disabled
@ncdiehl11 ncdiehl11 requested review from koji and jerader May 7, 2024 16:20
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 7, 2024 16:20
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 7, 2024 16:20
koji
koji approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thank you for fixing this!

@ncdiehl11 ncdiehl11 merged commit 16b94b5 into chore_release-7.3.0 May 7, 2024
26 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-protocolsetupstep-disabled branch May 7, 2024 16:43
@ncdiehl11 ncdiehl11 self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees

@ncdiehl11 ncdiehl11

Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @koji