refactor(app): refine file upload, input field components #15097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds focus state, file name truncation, test, and story for FileUpload component closes PLAT-292
brenthagen
requested review from
b-cooper
and removed request for
a team and
b-cooper
brenthagen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
adds focus state, file name truncation, test, and story for FileUpload component. removes InputField title error color.
https://www.figma.com/file/1ot18My22DALIcjdLl5LJh/Helix-Design-System?type=design&node-id=3318-8071&mode=design&t=B4PpAwONS2G3hsuR-0
closes PLAT-292, RQA-2689, RQA-2690, RQA-2701
Test Plan
test and story added
Changelog
Review requests
anything else missing from the component?
Risk assessment
low