Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): modify the space between icon and banner outline #15085

Merged
merged 1 commit into from
May 3, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented May 3, 2024

Overview

modify the space between icon and banner outline

design
https://www.figma.com/file/l7BAJAGICr10ELsSqQD0Sr/Design-System%3A-Desktop?node-id=7602-143972&mode=dev

[before]

padding bug on success inline notifcation

[after]

Screenshot 2024-05-02 at 5 25 53 PM

fix RQA-2649

Test Plan

Changelog

Review requests

Risk assessment

modify the space between icon and banner outline

close RQA-2649
@koji koji requested review from ncdiehl11 and jerader May 3, 2024 15:34
@koji koji marked this pull request as ready for review May 3, 2024 15:34
@koji koji requested a review from a team as a code owner May 3, 2024 15:34
@koji koji removed the request for review from a team May 3, 2024 15:41
@koji koji added the authorship label May 3, 2024
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@koji koji merged commit 02a1a16 into chore_release-7.3.0 May 3, 2024
30 checks passed
@koji koji deleted the fix_RQA-2649 branch May 3, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants