fix(step-generation): liquidState tracking for 96-channel column pickup #15076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
koji,
ncdiehl11 and
a team
and removed request for
a team
koji
approved these changes
May 2, 2024
koji
pushed a commit
that referenced
this pull request
May 3, 2024
koji
pushed a commit
that referenced
this pull request
May 3, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RESC-246 AUTH-373
Overview
This PR fixes a bug in the liquid state tracking specifically for using a 96-channel column partial tip configuration. The bug was that I forgot to consider partial tip for the 96-channel in the liquid state tracking all together so the protocol in the RESC ticket was tracking liquids as if all 96 nozzles were being used instead of 1 column
Test Plan
Upload the protocol attached to the RESC ticket on edge. The last transfer step should have a "not enough liquid in wells" warning. Upload the same protocol on this branch. The last transfer step should NOT have a "not enough liquid in wells" warning.
Changelog
Review requests
see test plan
Risk assessment
low