Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(system-server): sanitize the filename in the upload_splash endpoint for OEM Mode. #15063

Merged
merged 2 commits into from
May 1, 2024
Merged

fix(system-server): sanitize the filename in the upload_splash endpoint for OEM Mode. #15063

merged 2 commits into from
May 1, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented May 1, 2024 •
edited
Loading

Overview

Bash does not like spaces or weird characters when loading the custom logo in OEM Mode, so let's sanitize the filename by removing all non-alphanumeric characters.

Fixes: RQA-2668

Test Plan

  • Make sure that all non-alphanumeric characters are stripped from the filename
  • Make sure that the image from the bug ticket Userspace - Pfizer (max width).png displays correctly on bootup.

Changelog

  • replace all non-alphanumeric characters except for period with underscore (_) when processing the image filename

Review requests

Risk assessment

Low

@vegano1 vegano1 requested a review from a team as a code owner May 1, 2024 17:13
@vegano1 vegano1 requested review from brenthagen and CaseyBatten May 1, 2024 17:13
sfoster1
sfoster1 approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just might be worth setting the extension explicitly

system-server/system_server/system/oem_mode/router.py Show resolved Hide resolved
@vegano1
allow dashes
577438d 
set the file extension explicitly
@vegano1 vegano1 merged commit 78ac8fc into edge May 1, 2024
6 checks passed
@vegano1 vegano1 deleted the oem-mode-sanatize-upload-splash-filename branch May 1, 2024 19:30
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@vegano1 @Carlos-fernandez
fix(system-server): sanitize the filename in the upload_splash endpoi…
8f6aa71 
…nt for OEM Mode. (#15063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brenthagen brenthagen brenthagen approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

@CaseyBatten CaseyBatten Awaiting requested review from CaseyBatten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vegano1 @sfoster1 @brenthagen