fix(app,components): fix add a new case to info screen for labware #15041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix add a new case to info screen for close RQA-2648
mjhuff
approved these changes
Apr 30, 2024
|
@mjhuff thank you for reviewing! |
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
…15041) * fix(app,components): fix add a new case to info screen for labware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix add a new case to info screen for
close RQA-2648
Overview
fix add a new case to info screen for Labware.
For InfoScreen, we are passing
t, but in my understanding it never works since there is no information that we can retrieve by a key.I think we should remove
tsince ui components should not include i18n.What do you think about this? @ncdiehl11 @jerader
[before]
[after]
close RQA-2648
Test Plan
Changelog
Review requests
Risk assessment