fix(app): add grey square for stale and error protocol map #15016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These kind of look like close or delete buttons. Like, I would expect if I clicked on the "x" the stale protocol would be removed from the list. (I know this isn't the case.) |
@mmencarelli I've gotten this feedback from a few devs as well - do we still want to move forward with the x icon? |
smb2268
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-2634
Overview
Implement designs for stale protocol state deck map - now a grey square with rounded edges
Test Plan
Look at choose a protocol slideout and desktop protocols tab to view failed and stale protocols
Changelog
Updated Choose a Protocol Slideout and Protocol Card to show grey square (rounded edges)
Review requests
Test this out
Risk assessment
Low