Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add GET /deck_configuration notification support #15007

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Apr 25, 2024

Closes EXEC-263

Overview

This is the FE equivalent of #14986. Refactors GET /deck_configuration to use notifications.

Test Plan

  • First, push feat(robot-server): add deck_configuration notification publisher #14986 to a robot. You may verify notifications for deck config are emitted by following the test plan in that PR.
  • Open the network tab and go to some page/modal with deck config. Verify there is no polling.
  • Alter the deck config. Depending on which deck config you're using, the exact manner in which the data is sent to the server varies, but you should at some point see generally 1-2 network requests to deck_configuration.

Changelog

  • Add desktop app & ODD MQTT support to GET /deck_configuration.

Risk assessment

low - this is probably the most straightforward of all routes.

@mjhuff mjhuff requested review from a team April 25, 2024 14:00
@mjhuff mjhuff requested a review from a team as a code owner April 25, 2024 14:00
@mjhuff mjhuff requested review from brenthagen and removed request for a team and brenthagen April 25, 2024 14:00
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with a Flex and this branch worked as expected.
the changes look good to me.

I just left 2 comments, but they are just coding style.

@mjhuff mjhuff merged commit e53226a into edge Apr 25, 2024
20 checks passed
@mjhuff mjhuff deleted the app_deck-configuration-to-notifications branch April 25, 2024 16:17
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
Closes EXEC-263

Refactors GET /deck_configuration to use notifications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants