Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol-designer): minimize and extend position and tuberac… #14998

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 24, 2024

…k warnings

closes AUTH-370 AUTH-371

Overview

This PR addresses 2 issues that were documents by Anothony from testing PD

  1. the tuberack aspirating/dispensing too low into the well warnings were overbearing since it showed 2 warnings in one step. so this PR combines them
  2. the x/y position warning banner only existed for x/y and not the z position, so this PR includes the z position as well

Test Plan

Create a flex or ot-2 protocol and go to the deck map. Add a tube rack. Add an aspirate/dispense into the tube rack and see that a form warning shows up saying that the default aspirate/dispense height is close to the bottom of the well. NOTE: in order to trigger this warning, you need to add both an aspirate and dispense labware location and click out of the dropdown, this is the legacy behavior for all form warnings in PD where you have to click out of the field to trigger it.

Now, adjust the tip position field and add a custom z position that = 0, see that the warning banner shows up

Screenshot 2024-04-24 at 13 36 47 Screenshot 2024-04-24 at 13 34 46

Changelog

  • add banner logic for z position
  • refactor the aspirate/dispense in tuberack warning to be combined

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner April 24, 2024 17:38
@jerader jerader requested review from koji and ncdiehl11 and removed request for a team April 24, 2024 17:40
@koji
Copy link
Contributor

koji commented Apr 24, 2024

nit
seems that the padding is not needed?
Screenshot 2024-04-24 at 4 56 41 PM

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments, but the sandbox worked as expected.
the changes look good to me.

@jerader jerader merged commit 04e00ad into edge Apr 25, 2024
14 checks passed
@jerader jerader deleted the pd_fix-warning-text branch April 25, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants