refactor(protocol-designer): minimize and extend position and tuberac… #14998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…k warnings
closes AUTH-370 AUTH-371
Overview
This PR addresses 2 issues that were documents by Anothony from testing PD
Test Plan
Create a flex or ot-2 protocol and go to the deck map. Add a tube rack. Add an aspirate/dispense into the tube rack and see that a form warning shows up saying that the default aspirate/dispense height is close to the bottom of the well. NOTE: in order to trigger this warning, you need to add both an aspirate and dispense labware location and click out of the dropdown, this is the legacy behavior for all form warnings in PD where you have to click out of the field to trigger it.
Now, adjust the tip position field and add a custom z position that = 0, see that the warning banner shows up
Changelog
Review requests
see test plan
Risk assessment
low