feat(opentrons-ai-client): add prompt button #14970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add prompt button component close AUTH-
|
|
Looks good, just a note that when 100% zoomed on Chrome, the text area appears to be cut off a bit. Also just confirming that the intended behavior is for the clicked prompt button is to remain darker after click |
yeah, that happens because the height of SidePanel and this is a known issue. Oh thanks, the button's behavior you mentioned isn't expected. I will fix it. |
ncdiehl11
reviewed
Apr 23, 2024
| setPrompt(prompt) | ||
| }, [setPrompt, buttonText]) | ||
|
|
||
| return <PromptBtn onClick={handleClick}>{buttonText}</PromptBtn> |
There was a problem hiding this comment.
LGTM once the clicked style of PromptBtn is fixed! 👍
ncdiehl11
approved these changes
Apr 23, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* feat(opentrons-ai-client): add prompt button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add prompt button component and use it in InputPrompt component.
Textarea's CSS will be updated in a following PR
Screen.Recording.2024-04-23.at.8.54.41.AM.mov
close AUTH-334
Test Plan
Changelog
Review requests
Risk assessment
low