fix(app): resolve module location conflicts through deck config during protocol setup on ODD #14966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixture name At the beginning of the module calibration flow, the user is asked to locate the module on the deck. This integrated the deck configurator component directly into this location selction step of the module calibration wizard. the selected location will now be saved directly to deck configuration. Closes RQA-2603
…g protocol setup on ODD Resolve location conflicts in the on device display's protocol setup flow by updating deck configuration accordingly. Closes PLAT-287
b-cooper
requested review from
ncdiehl11,
brenthagen,
CaseyBatten and
mjhuff
and removed request for
a team and
ncdiehl11
mjhuff
reviewed
Apr 22, 2024
brenthagen
approved these changes
Apr 23, 2024
| const attachedModules = useModulesQuery().data?.data ?? [] | ||
| const history = useHistory() | ||
| const currentRunId = useCurrentRunId() | ||
| const { stopRun } = useStopRunMutation() |
There was a problem hiding this comment.
should this be useDismissCurrentRunMutation? stop run doesn't navigate away from the run setup/modal
There was a problem hiding this comment.
Oh good call, we may actually have to do both. I'll look into dismissing an un-started idle run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolve location conflicts in the on device display's protocol setup flow by updating deck
configuration accordingly.
Closes PLAT-287, PLAT-291
Review requests
Risk assessment
low