-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data, protocol-designer): return latest pipette model def f… #14945
Conversation
...l-designer/src/components/StepEditForm/fields/FlowRateField/__tests__/FlowRateField.test.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/FlowRateField/index.tsx
Outdated
Show resolved
Hide resolved
![]() not an issue but it's a little bit un-user-friendly since the default is 3.78 but we don't allow users to use 1 decimal place. For the error message, maybe @ecormany any thought on the above error message? |
I don't think we should restrict the number of decimals entered, since the Python API doesn't. Any valid float between the mix and max for the pipette–tip combo should be fine. I just tested this on 2.17:
which simulates as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few e2e test errors.
But the changes look to me.
@koji oops good catch! i didn't notice |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14945 +/- ##
==========================================
+ Coverage 67.50% 75.77% +8.27%
==========================================
Files 2521 29 -2492
Lines 72090 2180 -69910
Branches 9311 0 -9311
==========================================
- Hits 48666 1652 -47014
+ Misses 21228 528 -20700
+ Partials 2196 0 -2196
Flags with carried forward coverage won't be shown. Click here to find out more. |
…rom pipetteName and add max flow rates
closes AUTH-243 AUTH-245
Overview
Sorry this should really be 2 PRs but realized I needed the shared-data changes in order to properly test the protocol-designer changes.
This PR does 2 things:
3.0
,2.0
, etc) are prototypes so we shouldn't use them.uiMaxFlowRate
keyTest Plan
Changelog
Review requests
see test plan
Risk assessment
low