Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): reset robot and protocol slideout states on close #14939

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 17, 2024

closes RQA-2572

Overview

When a user clicks out of a ChooseRobot or ChooseProtocol slideout, the slideout should

  1. reset to the first page if a multi-page slideout
  2. reset default robot or protocol selection to the first valid option if one exists, and
  3. restore runtime parameter values to default if setting up protocol.

Note that if a user is on runtime parameters step and selects 'Change robot', any overriden parameter values will persist when parameter setup screen is proceeded to again.

Screen.Recording.2024-04-17.at.3.37.26.PM.mov

Test Plan

ChooseProtocolSlideout

  • Select a robot
  • Select overflow menu > run a protocol
  • Select an RTP protocol
  • Continue to parameters
  • Enter override values
  • Close slideout
  • Reopen slideout by again selecting overflow menu > run a protocol
  • Verify that you land back on protocol selection page and selected protocol is reset to first option

ChooseRobotToRunProtooclSlideout

  • Select a protocol
  • Select Start setup
  • Select a robot
  • Continue to parameters
  • Enter override values
  • Close slideout
  • Reopen slideout by again selecting Start setup
  • Verify that you land back on robot selection page and selected robot is reset to first option
  • Continue to parameters again
  • Enter override values
  • Select "change robot" and select a new robot
  • Continue to parameters again
  • Verify that parameter overrides persist

Changelog

  • add behavior to onCloseClick callback to reset slideout page number and parameter values

Review requests

auth

Risk assessment

low

When a user clicks out of a ChooseRobot or ChooseProtocol slideout, the slideout should 1) reset to
the first page if a multi-page slideout, 2) reset default robot or protocol selection to the first
valid option if one exists, and 3) restore runtime parameter values to default if setting up
protocol. Note that if a user is on runtime parameters step and selects 'Change robot', any
overriden parameter values will persist when parameter setup screen is proceeded to again.
@ncdiehl11 ncdiehl11 requested review from koji, shlokamin and jerader April 17, 2024 19:36
@ncdiehl11 ncdiehl11 self-assigned this Apr 17, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 17, 2024 19:46
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 17, 2024 19:46
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the app worked as expected.

@ncdiehl11 ncdiehl11 merged commit f3e966a into edge Apr 17, 2024
24 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-reset-slideouts branch April 17, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants