Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): disable 'Run a protocol' robot overflow menu item if robot is busy #14916

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 16, 2024

closes RQA-2570

Overview

Rather than removing the 'Run a protocol' menu item if the robot is busy, here, I render and disable the menu item with a hover tooltip.

Test Plan

  • create conditions where robot is busy (calibration in progress, update in progress, run in progress, e-stop engaged or disconnected)
  • navigate to robot card on Devices landing
  • open overflow menu
  • verify that Run a protocol menu item renders but is disabled
  • verify that hovering the menu item produces a 'Robot is busy' tooltip
Screenshot 2024-04-16 at 12 06 46 PM

Changelog

  • disable 'Run a protocol' menu item if robot is busy
  • update tests

Review requests

js

Risk assessment

low

…busy

Rather than removing the 'Run a protocol' menu item if the robot is busy, here, I render and disable
the menu item with a hover tooltip.
@ncdiehl11 ncdiehl11 requested a review from koji April 16, 2024 16:08
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 16, 2024 16:08
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 16, 2024 16:08
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thank you for fixing this!

@ncdiehl11 ncdiehl11 merged commit df1d203 into edge Apr 16, 2024
26 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-disable-overflow-menu-robot-busy branch April 16, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants