Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): add pipette selection screen to quick transfer flow #14912

Merged
merged 5 commits into from
Apr 16, 2024
Merged

feat(app): add pipette selection screen to quick transfer flow #14912

merged 5 commits into from
Apr 16, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Apr 15, 2024

fix PLAT-174

Overview

Add pipette selection screen to quick transfer flow
Screen Shot 2024-04-15 at 5 29 00 PM
Screen Shot 2024-04-15 at 5 29 08 PM
Screen Shot 2024-04-15 at 5 38 09 PM

Test Plan

Initiate quick transfer flow and proceed to the second screen, see that the pipettes currently attached are represented and you can select one and proceed to the next step

Changelog

  1. Update LargeButton to make icon optional and add subtext to be in line with design system
  2. Add SelectPipette screen and all test cases
  3. Update type for stored pipette data from AttachedPipette to PipetteSpecsV2 and Mount

Review requests

Go through code for clarity

Risk assessment

Low, behind FF

@smb2268 smb2268 self-assigned this Apr 15, 2024
@smb2268 smb2268 requested a review from a team as a code owner April 15, 2024 21:39
mjhuff
mjhuff approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and works as expected! Just a couple nits and @jerader's feeback.

app/src/organisms/QuickTransferFlow/index.tsx Outdated Show resolved Hide resolved
app/src/organisms/QuickTransferFlow/index.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make ORDERED_STEP_HEADERS a useGetOrderedStepHeader util?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be removed once all of the steps are wired up since the headers will be in each child component, so going to leave this for now!

@smb2268 smb2268 requested a review from a team as a code owner April 16, 2024 18:46
@smb2268 smb2268 merged commit 385d123 into edge Apr 16, 2024
23 checks passed
@smb2268 smb2268 deleted the app_quick-transfer-pipette branch April 16, 2024 19:10
@smb2268 smb2268 mentioned this pull request Apr 17, 2024
Merged
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@smb2268 @Carlos-fernandez
feat(app): add pipette selection screen to quick transfer flow (#14912)
0a3e387 
fix PLAT-174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader left review comments

@mjhuff mjhuff mjhuff approved these changes

@b-cooper b-cooper Awaiting requested review from b-cooper

@brenthagen brenthagen Awaiting requested review from brenthagen

Assignees

@smb2268 smb2268

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smb2268 @mjhuff @jerader