-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): factory mode desktop toggle #14911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation provider implements a localization provider for the ODD app that substitutes anonymous translation values when the "enableOEMMode" robot setting is on. pushes the localization provider further down the DOM to be within the ODD api host provider for the robot settings request, and splits out a separate instance for the desktop app. refactors the OnDeviceDisplayApp file a bit to avoid unnecessary rerenders of providers - currently the entire app rerenders on every route change because of the scroll ref. adds api client and react api client functions for robot settings get requests. closes PLAT-265
brenthagen
requested review from
mjhuff
and removed request for
a team and
mjhuff
April 15, 2024 21:16
b-cooper
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌱
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
adds the advanced setting toggle to enable factory mode. following work will add password protection and logo upload
closes PLAT-280, PLAT-282
Test Plan
Changelog
Review requests
check the desktop toggle with a robot/dev kit running an edge build - the ODD should restart in OEM mode
Risk assessment
low