Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): refactor banner component stories #14894

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 13, 2024

Overview

refactor banner component stories

close AUTH-342

Test Plan

Changelog

  • update Banner stories remove Story type
  • update Banner component import statement
  • clean up Banner component tests

Review requests

Risk assessment

low

refactor banner component stories

close AUTH-
@koji koji requested review from ncdiehl11 and jerader April 13, 2024 02:56
@koji koji marked this pull request as ready for review April 13, 2024 02:56
@koji koji requested a review from a team as a code owner April 13, 2024 02:56
@koji koji removed the request for review from a team April 13, 2024 02:56
it('renders success banner', () => {
const { getByText, getByLabelText } = render(props)
Copy link
Collaborator

@jerader jerader Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing these!

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🦋

@koji koji merged commit dc093fb into edge Apr 15, 2024
30 checks passed
@koji koji deleted the refactor-banner-stories branch April 15, 2024 19:07
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* refactor(app): refactor banner component stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants