Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol-designer): export modal to require app 7.3.0 or higher #14890

Merged
merged 1 commit into from
Apr 12, 2024
Merged

refactor(protocol-designer): export modal to require app 7.3.0 or higher #14890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocol-designer/cypress/integration/migrations.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ describe('Protocol fixtures migrate and match snapshots', () => {

cy.get('div')
.contains(
'This protocol can only run on app and robot server version 7.2.0 or higher'
'This protocol can only run on app and robot server version 7.3.0 or higher'
)
.should('exist')
cy.get('button').contains('continue', { matchCase: false }).click()
Expand Down
8 changes: 4 additions & 4 deletions protocol-designer/src/components/FileSidebar/FileSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,9 @@ export function v8WarningContent(t: any): JSX.Element {
return (
<div>
<p>
{t(`hint.export_v8_1_protocol_7_2.body1`)}{' '}
<strong>{t(`hint.export_v8_1_protocol_7_2.body2`)}</strong>
{t(`hint.export_v8_1_protocol_7_2.body3`)}
{t(`hint.export_v8_1_protocol_7_3.body1`)}{' '}
<strong>{t(`hint.export_v8_1_protocol_7_3.body2`)}</strong>
{t(`hint.export_v8_1_protocol_7_3.body3`)}
</p>
</div>
)
Expand Down Expand Up @@ -350,7 +350,7 @@ export function FileSidebar(): JSX.Element {
content: React.ReactNode
} => {
return {
hintKey: 'export_v8_1_protocol_7_2',
hintKey: 'export_v8_1_protocol_7_3',
content: v8WarningContent(t),
}
}
Expand Down
4 changes: 2 additions & 2 deletions protocol-designer/src/localization/en/alert.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@
"title": "Missing labware",
"body": "One or more module has no labware on it. We recommend you add labware before proceeding"
},
"export_v8_1_protocol_7_2": {
"export_v8_1_protocol_7_3": {
"title": "Robot and app update may be required",
"body1": "This protocol can only run on app and robot server version",
"body2": "7.2.0 or higher",
"body2": "7.3.0 or higher",
"body3": ". Please ensure your robot is updated to the correct version."
},
"change_magnet_module_model": {
Expand Down
2 changes: 1 addition & 1 deletion protocol-designer/src/localization/en/modal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"body3": "Adjust horizontal position within a well when aspirating, dispensing, or mixing.",
"body4": "Assign up to three types of tip racks to a single pipette.",
"body5": "Add multiple Temperature Modules to the deck (Flex only).",
"body6": "All protocols require {{app}} version <strong>7.2.0 or later</strong> to run."
"body6": "All protocols require {{app}} version <strong>7.3.0 or later</strong> to run."
}
},
"labware_selection": {
Expand Down
2 changes: 1 addition & 1 deletion protocol-designer/src/tutorial/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ type HintKey = // normal hints
| 'waste_chute_warning'
// blocking hints
| 'custom_labware_with_modules'
| 'export_v8_1_protocol_7_2'
| 'export_v8_1_protocol_7_3'
| 'change_magnet_module_model'
// DEPRECATED HINTS (keep a record to avoid name collisions with old persisted dismissal states)
// 'export_v4_protocol'
Expand Down
Loading