-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opentron-ai-client): add Side Panel component #14886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add sidebar component, its test and its stories close AUTH-208
jerader
reviewed
Apr 12, 2024
@@ -1,6 +1,7 @@ | |||
export const FLEX_NONE = 'none' | |||
export const FLEX_AUTO = 'auto' | |||
export const FLEX_MIN_CONTENT = 'min-content' | |||
export const FLEX_MAX_CONTENT = 'max-content' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh good idea
jerader
reviewed
Apr 12, 2024
jerader
reviewed
Apr 12, 2024
jerader
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storybook looks awesome. lgtm
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* feat(opentron-ai-client): add Side Panel component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add Side Panel component, test, and stories.
[design]
https://www.figma.com/file/6de3DHeR9o4q56Hd4S3YTb/ChatGPT-for-SLAS?node-id=1020%3A2177&mode=dev
close AUTH-208
Test Plan
make -C components dev
Check
AI
SidePanelChangelog
Review requests
Risk assessment
low