Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api,shared-data): Require Python >=3.10, not >=3.8 #14867

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Apr 11, 2024

Overview

Closes EXEC-391.

Test Plan

Not sure. Is there a way to do something like a private PyPI deploy to test this?

Changelog

  • Remove Python 3.8 and 3.9 from CLASSIFIERS. As far as I know, these are just human-readable tags, and don't have any behavioral effect.
  • Change python_requires from >=3.8 to >=3.10 for api and shared-data.

Mercifully, I think we can do this without having to do another pipenv lock, which would conflict #14805. pipenv verify doesn't complain.

Review requests

Other than api and shared-data, are there any other user-facing projects that this needs to happen in?

Risk assessment

Low.

@SyntaxColoring SyntaxColoring marked this pull request as ready for review April 11, 2024 14:39
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner April 11, 2024 14:39
@SyntaxColoring
Copy link
Contributor Author

The "shared-data test/lint/deploy" workflow is failing for reasons unrelated to this PR; it's broken in edge too.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, but also check hardware (I think it's fine though)

@SyntaxColoring
Copy link
Contributor Author

Looks like hardware is already narrowed to 3.10.

@SyntaxColoring SyntaxColoring merged commit ee6ff25 into edge Apr 11, 2024
55 of 58 checks passed
@SyntaxColoring SyntaxColoring deleted the tighten_python_requirement branch April 11, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants