Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update software keyboard ref type #14860

Merged
merged 2 commits into from
Apr 12, 2024
Merged

fix(app): update software keyboard ref type #14860

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a55e2
fix(app): update software keyboard ref type
koji Apr 10, 2024
c7534da
address feedback
koji Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/atoms/SoftwareKeyboard/AlphanumericKeyboard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import * as React from 'react'
import Keyboard from 'react-simple-keyboard'
import { alphanumericKeyboardLayout, customDisplay } from '../constants'
import type { KeyboardReactInterface } from 'react-simple-keyboard'

import '../index.css'
import './index.css'

// TODO (kk:04/05/2024) add debug to make debugging easy
interface AlphanumericKeyboardProps {
onChange: (input: string) => void
keyboardRef: React.MutableRefObject<any>
keyboardRef: React.MutableRefObject<KeyboardReactInterface | any>
koji marked this conversation as resolved.
Show resolved Hide resolved
debug?: boolean
}

Expand Down
3 changes: 2 additions & 1 deletion app/src/atoms/SoftwareKeyboard/FullKeyboard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import * as React from 'react'
import { KeyboardReact as Keyboard } from 'react-simple-keyboard'
import { customDisplay, fullKeyboardLayout } from '../constants'
import type { KeyboardReactInterface } from 'react-simple-keyboard'

import '../index.css'
import './index.css'

// TODO (kk:04/05/2024) add debug to make debugging easy
interface FullKeyboardProps {
onChange: (input: string) => void
keyboardRef: React.MutableRefObject<any>
keyboardRef: React.MutableRefObject<KeyboardReactInterface | any>
debug?: boolean
}

Expand Down
4 changes: 2 additions & 2 deletions app/src/atoms/SoftwareKeyboard/IndividualKey/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react'
import { KeyboardReact as Keyboard } from 'react-simple-keyboard'

import type { KeyboardReactInterface } from 'react-simple-keyboard'
import '../index.css'
import './index.css'

Expand All @@ -11,7 +11,7 @@ const customDisplay = {
// TODO (kk:04/05/2024) add debug to make debugging easy
interface IndividualKeyProps {
onChange: (input: string) => void
keyboardRef: React.MutableRefObject<null>
keyboardRef: React.MutableRefObject<KeyboardReactInterface | null>
keyText: string
debug?: boolean
}
Expand Down
4 changes: 3 additions & 1 deletion app/src/atoms/SoftwareKeyboard/NumericalKeyboard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
import * as React from 'react'
import { KeyboardReact as Keyboard } from 'react-simple-keyboard'
import { numericalKeyboardLayout, numericalCustom } from '../constants'

import type { KeyboardReactInterface } from 'react-simple-keyboard'
import '../index.css'
import './index.css'

// Note (kk:04/05/2024) add debug to make debugging easy
interface NumericalKeyboardProps {
onChange: (input: string) => void
keyboardRef: React.MutableRefObject<null>
keyboardRef: React.MutableRefObject<KeyboardReactInterface | null>
isDecimal?: boolean
hasHyphen?: boolean
debug?: boolean
Expand Down
Loading