Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): add input screen for ODD numerical runtime parameters #14858

Merged
merged 12 commits into from
Apr 11, 2024
Merged

feat(app): add input screen for ODD numerical runtime parameters #14858

merged 12 commits into from
Apr 11, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 10, 2024 •
edited by jira bot
Loading

closes AUTH-121
closes AUTH-122
closes AUTH-224
closes AUTH-320

Overview

add screen for int and float RTP input on ODD

Test Plan

  1. Push this branch to ODD
  2. Send a int/float-containing RTP protocol to the flex
  3. Walk through numerical input flow

Changelog

Review requests

authorship devs

Risk assessment

low

@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 10, 2024 18:40
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 10, 2024 18:40
@ncdiehl11 ncdiehl11 requested review from jerader and koji and removed request for a team April 10, 2024 18:40
@ncdiehl11 ncdiehl11 requested a review from koji April 10, 2024 21:47
koji
koji approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for working on Software Keyboard weirdness 😄

@ncdiehl11 ncdiehl11 merged commit 8bb14f4 into edge Apr 11, 2024
45 of 48 checks passed
@ncdiehl11 ncdiehl11 deleted the feat_app-odd-rtp-number-screen branch April 11, 2024 14:10
@ncdiehl11
Copy link
Collaborator Author

Merged despite failing test as 7.2.2 mergeback to edge broke a shared-data test that was not implicated in this PR.

Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@ncdiehl11 @Carlos-fernandez
feat(app): add input screen for ODD numerical runtime parameters (#14858
ccdec0f 
)

closes AUTH-121, AUTH-122, AUTH-224, AUTH-320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader jerader is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdiehl11 @koji @ncdiehl