fix(protocol-designer): auto-generate trashBin for flex if no pipetting commands exist

[jerader]

closes AUTH-267

Overview

In PD in production, if you create a Flex protocol with no pipetting steps and reupload it to the app, it does not auto generate a trash bin for you. Technically there is a way around it by adding a trash bin entity. But its a weird state because return tip and no trash entity is not supported in PD.

Ot-2 does not have this issue because it always ensures a hardcoded fixed trash is generated

So this PR auto-generates a trash bin for a flex if there is none when importing a protocol.

Test Plan

I created a test case to test all scenarios, so it should work as expected.

However, you can create a flex protocol and add a pause step. Download the protocol and reimport it back to PD. See that the trash bin is generated.

Changelog

• create util for getting an unoccupied slot, taking into account modules, labwares, move labware commands, waste chute, and staging area slots
• add test

Review requests

see test plan

Risk assessment

low

[jerader]

now unnecessary logic since we are listing 'A3' as the first cutout in the array to map through

[koji]

question

when I added waste chute, export and import the protocol into pd, trash bin is generated but waste chute is gone.
Is this expected behavior?

[jerader]

question

when I added waste chute, export and import the protocol, trash bin is generated but waste chute is gone. Is this expected behavior?

@koji oops that is definitely a bug! Thanks for catching it.

[jerader]

question
when I added waste chute, export and import the protocol, trash bin is generated but waste chute is gone. Is this expected behavior?

@koji oops that is definitely a bug! Thanks for catching it.

@koji actually, if you did not add any waste chute commands, it is not a bug since we remove any staging area slot and waste chute that is not used in the protocol. But if you did add waste chute commands, it is a bug.

[koji]

question
when I added waste chute, export and import the protocol, trash bin is generated but waste chute is gone. Is this expected behavior?

@koji oops that is definitely a bug! Thanks for catching it.

@koji actually, if you did not add any waste chute commands, it is not a bug since we remove any staging area slot and waste chute that is not used in the protocol. But if you did add waste chute commands, it is a bug.

@jerader I added waste chute from the initial setup wizard.

[koji]

one more question

I compared two json.
left: exported json - no trash bin
right: import the left json and re-export (trash bin with auto generated)

making pipetteTiprackAssignments item nested (adding []) is an expected behavior?

left
no-trashbin.json

right
no-trashbin (1).json

[jerader]

one more question

I compared two json. left: exported json - no trash bin right: import the left json and re-export (trash bin with auto generated)

making pipetteTiprackAssignments item nested (adding []) is an expected behavior?

left no-trashbin.json

right no-trashbin (1).json

@koji oh i think what's happening is when you reimport, it goes through the 8.1 migration because the version when you export is 8.0.3 and not 8.1.0 - this is a current limitation with PD where the versioning doesn't update until i push a release tag 😦 so for now we have to manually change the version before we reimport.

This is a great catch though! i forgot that we have to do this.

[jerader]

question
when I added waste chute, export and import the protocol, trash bin is generated but waste chute is gone. Is this expected behavior?

@koji oops that is definitely a bug! Thanks for catching it.

@koji actually, if you did not add any waste chute commands, it is not a bug since we remove any staging area slot and waste chute that is not used in the protocol. But if you did add waste chute commands, it is a bug.

@jerader I added waste chute from the initial setup wizard.

@koji got it, this sounds like expected behavior. if you didn't add any step using the waste chute then it isn't being used in the protocol and won't generate upon reimport or even if you upload it to the app.

[koji]

thank you for answering to all my questions.
LGTM!