Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix rtp slideout issue #14855

Merged
merged 5 commits into from
Apr 11, 2024
Merged

fix(app): fix rtp slideout issue #14855

merged 5 commits into from
Apr 11, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 10, 2024

Overview

fix rtp slideout issue

  • remove description from choices
  • remove place holder for type: int/float

close AUTH-312

Test Plan

Changelog

Review requests

Risk assessment

low

@koji koji requested review from ncdiehl11 and jerader April 10, 2024 20:52
@koji koji marked this pull request as ready for review April 10, 2024 20:53
@koji koji requested a review from a team as a code owner April 10, 2024 20:53
@koji koji marked this pull request as draft April 10, 2024 21:00
@koji koji marked this pull request as ready for review April 10, 2024 21:10
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🦅

@koji koji merged commit a2c5a02 into edge Apr 11, 2024
24 checks passed
@koji koji deleted the fix_auth-312-rtp-desktop branch April 11, 2024 13:37
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(app): fix rtp slideout issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants