Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data, app): fix small issues in app #14851

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 10, 2024

Overview

fix small issues.

close AUTH-321

Test Plan

Changelog

  • add jsdoc to helper functions for rtp
  • add a missing test for a helper function
  • fix mock test small issue
  • remove unnecessary lines
  • remove console.log() from stories

Review requests

Risk assessment

low

fix small issues in app

close AUTH-321
@koji koji requested review from ncdiehl11 and jerader April 10, 2024 04:01
@koji koji marked this pull request as ready for review April 10, 2024 04:02
@koji koji requested a review from a team as a code owner April 10, 2024 04:02
@koji koji changed the title fix(app): fix small issues in app fix(shared-data, app): fix small issues in app Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.93%. Comparing base (65885b2) to head (40f858f).
Report is 38 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14851      +/-   ##
==========================================
+ Coverage   67.24%   75.93%   +8.68%     
==========================================
  Files        2495       40    -2455     
  Lines       71254     2722   -68532     
  Branches     8937        0    -8937     
==========================================
- Hits        47918     2067   -45851     
+ Misses      21235      655   -20580     
+ Partials     2101        0    -2101     
Flag Coverage Δ
api ?
app ?
components ?
g-code-testing ?
hardware ?
hardware-testing ?
labware-library ?
notify-server ?
ot3-gravimetric-test ?
protocol-designer ?
react-api-client ?
robot-server ?
shared-data 75.93% <ø> (ø)
step-generation ?
system-server ?
update-server ?
usb-bridge ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2454 files with indirect coverage changes

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Also thanks for making a test for formatRunTimeParameterDefaultValue

@koji koji merged commit f81da99 into edge Apr 10, 2024
40 checks passed
@koji koji deleted the fix_small-fixes-in-app branch April 10, 2024 12:40
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(shared-data, app): fix small issues in app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants