Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol-designer, components): infoItem to nicely accommoda… #14850

Merged
merged 4 commits into from
Apr 9, 2024
Merged

refactor(protocol-designer, components): infoItem to nicely accommoda… #14850

merged 4 commits into from
Apr 9, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 9, 2024

…te multiple tipracks

closes AUTH-314

Overview

Previously, the pipette section in PD was jumbled if you had multiple tipracks selected for the pipette. This PR makes it look prettier 💅

Screenshot 2024-04-09 at 15 10 16

Test Plan

Create a flex or ot-2 protocol and add multiple tips onto each pipette. Create protocol and examine the pipette section.

Changelog

  • list tiprack models via bulletpoints and remove now unnecessary component (InfoItem)
  • create test for InstrumentInfo

Review requests

see test plan

Risk assessment

low

@jerader jerader requested review from a team as code owners April 9, 2024 19:15
@jerader jerader requested review from TamarZanzouri, koji and ncdiehl11 and removed request for a team and TamarZanzouri April 9, 2024 19:15
@jerader jerader requested a review from koji April 9, 2024 21:14
koji
koji approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment but it's not a blocker to merge this into edge.
Could you create a ticket to track Storybook implementation for this component?
I guess the design team will need Storybook for DQA in the future.

@jerader jerader merged commit 57a8152 into edge Apr 9, 2024
46 checks passed
@jerader jerader deleted the pd_fix-instrument-item branch April 9, 2024 21:41
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@jerader @Carlos-fernandez
refactor(protocol-designer, components): infoItem to nicely accommoda… (
5bc704f 
#14850)

…te multiple tipracks

closes AUTH-314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerader @koji