Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(app): Adjust desktop app "moveToWell" command text font size #14849

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Apr 9, 2024

Closes RQA-2428

Overview

The "moveToWell" command text was never wrapped in StyledText, causing it to render at an improper font size on the desktop app. This did not impact the ODD, since command text is handled in a different component.

Current Behavior

Screenshot 2024-04-09 at 1 39 05 PM

With Fix

Screenshot 2024-04-09 at 2 17 05 PM

Test Plan

  • Verify using a protocol with a moveToWell command. See ticket for an attached protocol.

Risk assessment

low

@mjhuff mjhuff requested review from koji, ncdiehl11 and a team April 9, 2024 18:29
@mjhuff mjhuff requested a review from a team as a code owner April 9, 2024 18:29
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thank you for fixing this font size issue!

@mjhuff mjhuff merged commit 2a82fef into edge Apr 9, 2024
26 checks passed
@mjhuff mjhuff deleted the app_fix-move-text branch April 9, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants