Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): create container for all tipracks #14848

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 9, 2024

closes AUTH-313

Overview

Now, all tipracks are auto generated on the deck after initial protocol creation. And the tiprack option dropdown is modified to only include tipracks for that specific pipette that are on the deck.

Screenshot 2024-04-09 at 14 11 57

Screenshot 2024-04-09 at 14 11 26

Test Plan

Create a flex or ot-2 protocol. Perhaps flex might be better to add the max of 6 tipracks to the deck. For the pipette select both p1000s and selecting the first 3 tipracks for one and the other 3 tipracks for the 2nd pipette (this is so you select all 6 different tipracks)

Go to the deck map and see that all 6 tipracks are placed, starting with filling up the center column 2. (this is a Product decision since modules are by default placed in the outside slots with magnetic Block going in slot D2). Then the rest of the tipracks should fill up the next available slots.

Add a pipetting step and see that the dropdown menu for the tipracks shows only the pipette's default tipracks that you selected. Now delete the step and delete a tiprack. Create the step again and one pipette should only have 2 dropdown items now. If you hover over the dropdown field, a tooltip should show up saying that you are missing a tiprack.

Changelog

  • fix logic for auto-generating the tipracks
  • fix which tipracks are displayed in the tiprack options selector
  • add a test to tiprackField

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner April 9, 2024 18:12
@jerader jerader requested review from koji, ncdiehl11 and a team and removed request for a team April 9, 2024 18:13
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sandbox worked as expected without the case I sent.

@jerader
Copy link
Collaborator Author

jerader commented Apr 9, 2024

the sandbox worked as expected without the case I sent.

@koji thanks! I made this ticket to address the bug you found https://opentrons.atlassian.net/browse/AUTH-319

@jerader jerader merged commit 476149e into edge Apr 9, 2024
14 checks passed
@jerader jerader deleted the pd_multi-tip-all-tipracks branch April 9, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants