Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data, app): fix runtime parameters range display #14847

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 9, 2024

Overview

before
Screenshot 2024-04-09 at 9 37 19 AM

after
Screenshot 2024-04-09 at 12 57 02 PM

close AUTH-316

Test Plan

Changelog

  • add a new util function to shared-data helper and its test
  • use the new util function in app and odd

Review requests

Risk assessment

@koji koji requested review from ncdiehl11 and jerader April 9, 2024 17:13
@koji koji marked this pull request as ready for review April 9, 2024 17:13
@koji koji requested a review from a team as a code owner April 9, 2024 17:13
@koji koji removed the request for review from a team April 9, 2024 17:13
}

/**
* This function sorts an array of strings in numerical and alphabetical order.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just a few comments

@koji koji merged commit e345d32 into edge Apr 9, 2024
47 checks passed
@koji koji deleted the fix_runtime-parameters-range-options-order branch April 9, 2024 18:41
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(shared-data, app): fix runtime parameters range display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants