Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): format rtp float and int choices to include suffix #14842

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 9, 2024

closes AUTH-311

Overview

display suffixes for int and float choices.

Test Plan

Upload the attached protocol in the ticket and see that the default and updates values in the table display the suffixes for choices that are type int and float

Changelog

  • modify the 2 utils and fix the test. choices type can be an int and float so i had to remove it from the switch block

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner April 9, 2024 13:18
@jerader jerader requested review from koji and ncdiehl11 and removed request for a team April 9, 2024 13:18
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the quick fix!
lgtm!

@jerader jerader merged commit cc084a4 into edge Apr 9, 2024
44 of 45 checks passed
@jerader jerader deleted the app_add-suffix-to-int-float branch April 9, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants