Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): magnetic form correct engage height ranges #14841

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 9, 2024

closes RQA-2490, AUTH-269

Overview

Adjust the ranges for min and max engage height for a magnetic module gen1 and gen2. This updates also removes the graphic and images in the magnet form.

Test Plan

Create an ot-2 protocol and add a magnetic module gen1. Go to the deck map view and add a magnet step. Select to add an engage height and see the range from 0 - 45. Try to input ranges that are outside and see that it errors when you click off of the input field.

Now create a new protocol with a gen2. Do the same steps, this time add the Opentrons Tough plate on top of the module. Add a magnet step and see the range from -2.5 - 25 and the recommended text for the labware's recommended height.

Changelog

  • delete now unneeded graphic and images
  • add the engage height text to the input field
  • add test coverage
  • update the constants

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner April 9, 2024 12:53
@jerader jerader requested review from koji, ncdiehl11 and a team and removed request for a team April 9, 2024 12:53
@koji
Copy link
Contributor

koji commented Apr 9, 2024

Question
For V1, engage height is allowed to use float?
I could set 44.5.

@jerader
Copy link
Collaborator Author

jerader commented Apr 9, 2024

Question For V1, engage height is allowed to use float? I could set 44.5.

@koji , ya that is the current behavior in production so i think we should stick with it.

@koji koji self-requested a review April 9, 2024 14:19
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments
the sandbox worked as expected and the changes make sense to me.

@jerader jerader merged commit 19d88ce into edge Apr 9, 2024
14 checks passed
@jerader jerader deleted the pd_magnet-form-engage-height branch April 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants