Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): update unused module alert to account for MoaM #14839

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 8, 2024

closes AUTH-23

Overview

the unused module alert is updated to add slot information.

Test Plan

Turn on the multiple modules FF!

Create a flex protocol and add 2 temperature modules. Go to the deck map and add a pipetting step but do not add a temperature step.

export the protocol and you should see an unused modules modal that mentions the slot information.

Changelog

  • update the unused modules alert text to make sense for multiple of the same type of modules
  • fix the test

Revew requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner April 8, 2024 19:37
@jerader jerader requested review from koji, ncdiehl11 and a team and removed request for a team April 8, 2024 19:37
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
the sandbox worked as expected.

@jerader jerader merged commit 2a717d7 into edge Apr 8, 2024
14 checks passed
@jerader jerader deleted the pd_unused-module-modal branch April 8, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants