refactor(app): remove RTP feature flag #14837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove RTP feature flag close AUTH-301
jerader
reviewed
Apr 8, 2024
| @@ -106,9 +105,10 @@ export function ChooseProtocolSlideoutComponent( | |||
|
|
|||
| const runTimeParametersFromAnalysis = | |||
| selectedProtocol?.mostRecentAnalysis?.runTimeParameters ?? [] | |||
| console.log('runTimeParametersFromAnalysis', runTimeParametersFromAnalysis) | |||
There was a problem hiding this comment.
Suggested change
| console.log('runTimeParametersFromAnalysis', runTimeParametersFromAnalysis) |
jerader
reviewed
Apr 8, 2024
jerader
reviewed
Apr 8, 2024
| @@ -83,22 +85,55 @@ describe('ChooseProtocolSlideout', () => { | |||
| screen.getByRole('heading', { name: 'No protocols found' }) | |||
| ).toBeInTheDocument() | |||
| }) | |||
| it('calls createRunFromProtocolSource if CTA clicked', () => { | |||
|
|
|||
| // it('calls createRunFromProtocolSource if CTA clicked', () => { | |||
There was a problem hiding this comment.
saw your comment on slack 👍
jerader
approved these changes
Apr 8, 2024
Co-authored-by: Jethary Rader <[email protected]>
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* refactor(app): remove RTP feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
remove RTP feature flag
close AUTH-301
I will update ChooseProtocolSlideout.test.tsx.
https://opentrons.atlassian.net/browse/AUTH-302
Test Plan
Changelog
Review requests
Risk assessment
low