Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): add RTP properties to protocol run event analytics #14836

Merged
merged 2 commits into from
Apr 24, 2024
Merged

refactor(app): add RTP properties to protocol run event analytics #14836

merged 2 commits into from
Apr 24, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 8, 2024 •
edited
Loading

closes AUTH-281

Overview

add analytics RTP properties for:

  1. whether protocol has RTP or not
  2. whether any RTP values are non-default

to protocol events as described in this doc.

Test Plan

Changelog

Review requests

authorship

Risk assessment

low

@ncdiehl11 ncdiehl11 changed the title refactor(app): add RTP properties to protocol event analytics refactor(app): add RTP properties to protocol run event analytics Apr 9, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 9, 2024 20:36
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 9, 2024 20:36
@ncdiehl11 ncdiehl11 requested review from shlokamin and removed request for a team April 9, 2024 20:36
jerader
jerader reviewed Apr 9, 2024
View reviewed changes
app/src/organisms/Devices/hooks/__tests__/useProtocolRunAnalyticsData.test.tsx
@@ -126,6 +138,8 @@ describe('useProtocolAnalysisErrors hook', () => {
protocolAppName: 'Python API',
protocolAppVersion: 2.3,
protocolAuthor: 'hashedString',
protocolHasRunTimeParameterCustomValues: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be good to add 2 more test cases where the protocol has custom values and has no parameters

jerader
jerader approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me! just left a comment about adding a bit more test coverage

@koji
Copy link
Contributor

koji commented Apr 9, 2024 •
edited
Loading

As we talked, proceedToRun is missing new props of RTP and robot serialNumber.
Once that part is solved, this PR is good to go.

@koji
Copy link
Contributor

koji commented Apr 16, 2024 •
edited
Loading

Seems that a few proceedToRun/ANALYTICS_PROTOCOL_PROCEED_TO_RUN don't to pass robotSerialNumber as a property.
open a PR. #14976 merged

koji
koji approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the branch with RTP protocol and non-RTP protocol and both cases worked as expected.
In terms of the new names, got the confirmation from Mike.

@koji koji merged commit 77bc720 into edge Apr 24, 2024
24 checks passed
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@ncdiehl11 @Carlos-fernandez
refactor(app): add RTP properties to protocol run event analytics (#1…
16b4d53 
…4836)

* refactor(app): add RTP properties to protocol run event analytics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@koji koji koji approved these changes

@shlokamin shlokamin Awaiting requested review from shlokamin shlokamin is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncdiehl11 @koji @jerader @ncdiehl