refactor(components): update Box stories #14827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Box stories close AUTH-294
jerader
reviewed
Apr 8, 2024
| 'This is a simple box atom that accepts all primitive styling props.', | ||
| backgroundColor: 'grey', | ||
| border: '1px solid black', | ||
| padding: '1rem', |
There was a problem hiding this comment.
do we want to use the constant here?
jerader
reviewed
Apr 8, 2024
| args: { | ||
| children: | ||
| 'This is a simple box atom that accepts all primitive styling props.', | ||
| backgroundColor: 'grey', |
There was a problem hiding this comment.
should we use a color in our color system?
jerader
reviewed
Apr 8, 2024
| children: | ||
| 'This is a simple box atom that accepts all primitive styling props.', | ||
| backgroundColor: 'grey', | ||
| border: '1px solid black', |
There was a problem hiding this comment.
same here, we can use a border constant
jerader
approved these changes
Apr 8, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* refactor(components): update Box stories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update Box stories
close AUTH-294
Test Plan
Changelog
Review requests
Risk assessment
low